Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space missing from data_formatter_template causing mismatch with response_template #455

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal commented Feb 5, 2025

Description of the change

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Copy link

github-actions bot commented Feb 5, 2025

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

… response_template

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@dushyantbehl
Copy link
Contributor

@Abhishek-TAMU @willmj if you are okay with this fix please merge...

@HarikrishnanBalagopal noticed this while debugging for an internal use case with @prince14322 that space was missing from the doc.

Copy link
Collaborator

@Abhishek-TAMU Abhishek-TAMU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea if response template is \n## Label: then this fix in data_formatter_template makes sense. Thank you for catching this. LGTM!

@willmj willmj merged commit 59a72cd into foundation-model-stack:main Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants